Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding "scriptingEnabled" option to source set #448

Merged
merged 1 commit into from
Jul 11, 2022

Conversation

echolimazulu
Copy link
Contributor

@echolimazulu echolimazulu commented Jul 5, 2022

Is an improvement and solution for the problem:
Issue 446

Changes:

  • added option "scriptingEnabled" for "source" object, affected src/utils.js;
  • added description and example of using "scriptingEnabled" option in README.md;
  • improved plugin: src/plugins/sources-plugin.js;
  • extended options structure: src/options.json;
  • extended test: test/sources-option.test.js;
  • extended test: test/validate-options.test.js;
  • added image: test/fixtures/noscript.png;
  • extended content: test/fixtures/simple.html;
  • snapshots generated, tests passed.

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Breaking Changes

Additional Info

- added option "scriptingEnabled" for "source" object, affected src/utils.js;
- added description and example of using "scriptingEnabled" option in README.md;
- improved plugin: src/plugins/sources-plugin.js;
- extended options structure: src/options.json;
- extended test: test/sources-option.test.js;
- extended test: test/validate-options.test.js;
- added image: test/fixtures/noscript.png;
- extended content: test/fixtures/simple.html;
- snapshots generated, tests passed.
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 5, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: echolimazulu / name: Evgenii Sokolov (4624b30)

@echolimazulu echolimazulu mentioned this pull request Jul 5, 2022
@codecov
Copy link

codecov bot commented Jul 10, 2022

Codecov Report

Merging #448 (4624b30) into master (b492065) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #448      +/-   ##
==========================================
+ Coverage   92.17%   92.20%   +0.02%     
==========================================
  Files           7        7              
  Lines         588      590       +2     
  Branches      188      190       +2     
==========================================
+ Hits          542      544       +2     
  Misses         37       37              
  Partials        9        9              
Impacted Files Coverage Δ
src/plugins/sources-plugin.js 100.00% <100.00%> (ø)
src/utils.js 90.11% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b492065...4624b30. Read the comment docs.

@alexander-akait alexander-akait merged commit 6ed9f9c into webpack-contrib:master Jul 11, 2022
@alexander-akait
Copy link
Member

Thank you

@echolimazulu
Copy link
Contributor Author

@alexander-akait Thank you for your cooperation! Glad to help your project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants