This repository has been archived by the owner on Jan 19, 2021. It is now read-only.
fix: use latest API (loader-utils)
#61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-ciniawsky
requested review from
bebraw,
alexander-akait and
michael-ciniawsky
| @@ -10,8 +10,8 @@ export default function (source, sourceMap) { | |||
| srcMap = inlineSourceMap.sourcemap; | |||
| } | |||
|
|
|||
| const userOptions = loaderUtils.parseQuery(this.query); | |||
| const instrumenter = istanbulLibInstrument.createInstrumenter( | |||
| const userOptions = loaderUtils.getOptions(this); | |||
There was a problem hiding this comment.
- const userOptions = loaderUtils.getOptions(this);
+ const userOptions = loaderUtils.getOptions(this) || {};loaderUtils.getOptions() returns null, if there aren't any options
There was a problem hiding this comment.
This is safe as passing null as an arg to Object.assign just has it skip it without an error Object.assign({foo: 'bar'}, null) == {foo: 'bar'}
https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_Objects/Object/assign
Closed
michael-ciniawsky
changed the title
loader-utils)
michael-ciniawsky
added
status: Approved
and removed
priority: 3 (required)
severity: 3 (broken)
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59
This repo could probably do with some tests that would have caught this, unfortunately I don't have time right now to contribute them as well. I tested it locally in my project and it worked ok with these changes.