Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support webpack@5 #330

Closed
victors1681 opened this issue Dec 24, 2018 · 11 comments
Closed

support webpack@5 #330

victors1681 opened this issue Dec 24, 2018 · 11 comments

Comments

@victors1681
Copy link

...... /node_modules/mini-css-extract-plugin/dist/index.js:217
      mainTemplate.hooks.requireEnsure.tap(pluginName, (source, chunk, hash) => {
                                       ^

TypeError: Cannot read property 'tap' of undefined
    at compiler.hooks.thisCompilation.tap.compilation (/Users/santosv/workspace/webpack-boilerplate/node_modules/mini-css-extract-plugin/dist/index.js:217:40)
    at SyncHook.eval [as call] (eval at create (/Users/santosv/workspace/webpack-boilerplate/node_modules/tapable/lib/HookCodeFactory.js:19:10), <anonymous>:9:1)
    at SyncHook.lazyCompileHook (/Users/santosv/workspace/webpack-boilerplate/node_modules/tapable/lib/Hook.js:154:20)
    at Compiler.newCompilation (/Users/santosv/workspace/webpack-
@davetron5000
Copy link

Looks like “MainTemplate.hooks.requireEnsure removed”: https://github.com/webpack/changelog-v5/blob/master/README.md#other-minor-changes

@alexander-akait
Copy link
Member

Feel free to send a PR

@hulkish
Copy link

hulkish commented Dec 31, 2018

related webpack/webpack#8537

@sibelius
Copy link

sibelius commented Jan 5, 2019

here a pull request example entria/entria-fullstack#46

@phaistonian
Copy link

Any ETA on this one?

@alexander-akait
Copy link
Member

No ETA, but when webpack@5 was released, plugin already support webpack@5

@phaistonian
Copy link

@evilebottnawi as I noticed in the feedback summary, it's stated that it's not compatible yet.

@Septdir
Copy link

Septdir commented Jul 30, 2020

I would really like to use mini-css-extract-plugin with webpack 5

However, it looks like it won't work before webpack 5release.
So far I have found an alternative.

extract-css-chunks-webpack-plugin

@ylemkimon
Copy link

I can confirm no warnings or errors are produced with webpack@>=5.0.0-beta.23 and mini-css-extract-plugin@^0.11.0. (#477, #571, #573)

@alexander-akait
Copy link
Member

Yes, fixing HMR is on our roadmap (current or next week), maybe we found time faster for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants