[WIP] Webpack@5 #46

matheus1lva · 2019-01-04T04:42:25Z

per #43 .

I reworked some files, moved some dependencies to the top level and updated some. Server still having issues to start due to what was already reported on #42.

It is a WIP, i still need to find a better way to clean cache when we change any webpack config. I'm gonna read the changelog and see what they suggest.

Otherwise, it's pretty complete i guess.

ps: some plugins/loaders on web package i had to comment it out, they are not ready to be moved to webpack5 yet (yeah, more breaking changes).

The following plugins are broken:
mini-css-extract-plugin
html-webpack-plugin

sibelius · 2019-01-04T09:52:36Z

lint and test are failing

can you check?

can you also list any issues of loaders to support webpack 5?

good job

sibelius · 2019-01-04T09:53:43Z

is it faster on first build?
is it faster on rebuild?
is it faster on HMR?

package.json

packages/web/src/App.tsx

matheus1lva · 2019-01-05T03:40:10Z

Tests are failing trying to load a .env file that probably is not being created when tests run (it is not created locally). How to proceed?
Everything else is fixed.

Now apparently webpack build stopped working and i have no idea why. I'm looking at it and also i'm still looking at those plugins that need to be updated.

packages/web/package.json

sibelius · 2019-01-05T11:23:37Z

the first run was 2000ms
the next run was 500ms

I nice improvement over the cache

I've got this problem https://github.com/shellscape/webpack-plugin-serve/blob/master/.github/FAQ.md#what-does-the-not-found--404-error-mean

maybe it is related to html-webpack-plugin

we can remove mini css, as we use styled-components, no need for directly css

sibelius · 2019-01-05T11:27:24Z

wps hmr client file is not being generated as well

sibelius · 2019-01-05T11:28:04Z

it is also not generating .cache directory

sibelius · 2019-01-05T11:32:52Z

Migrating html-webpack-plugin to 4 beta5 solves the problem with it

but it throws another error

Uncaught ReferenceError: global is not defined
    at eval (index.js?e792:25)
    at Object../node_modules/@babel/polyfill/lib/index.js (bundle.js:3822)
    at __webpack_require__ (bundle.js:24)
    at fn (bundle.js:4146)
    at eval (index.tsx:2)
    at Module../src/index.tsx (bundle.js:3951)
    at __webpack_require__ (bundle.js:24)
    at startup (bundle.js:46)
    at bundle.js:53
    at bundle.js:56

…a5 to work nice with wp5

sibelius · 2019-01-05T11:35:35Z

maybe related to webpack/webpack#8537 (comment)

matheus1lva · 2019-01-05T14:22:50Z

Interesting that it changed... I'm going to investigate if the behavior I was getting yesterday continues even with the beta version. Because not even with a python server the bundle was being executed (on web)

matheus1lva · 2019-01-05T17:10:37Z

maybe related to webpack/webpack#8537 (comment)

Yeah, apparently it is related. They moved the builtins to a runtime plugin, which apparently isn't working properly anymore... i'm going to track that down

matheus1lva · 2019-01-05T17:14:28Z

On normal builds, without a dev-server, it went from: 4s on first build to 2s on next builds.
Cache is being put on a .cache folder inside web/webpack and server/webpack

matheus1lva · 2019-01-07T23:47:47Z

Migrating html-webpack-plugin to 4 beta5 solves the problem with it

but it throws another error

Uncaught ReferenceError: global is not defined
    at eval (index.js?e792:25)
    at Object../node_modules/@babel/polyfill/lib/index.js (bundle.js:3822)
    at __webpack_require__ (bundle.js:24)
    at fn (bundle.js:4146)
    at eval (index.tsx:2)
    at Module../src/index.tsx (bundle.js:3951)
    at __webpack_require__ (bundle.js:24)
    at startup (bundle.js:46)
    at bundle.js:53
    at bundle.js:56

Fixed, but html-webpack-plugin still throwing errors due to incompatibility as we already expected (even with the beta version), this only happens after a successful build when you save a file.

@entria/web: TypeError: Cannot read property 'get' of undefined
@entria/web:     at childCompiler.fileDependencies.some (/home/matheus/projects/forks/entria-fullstack/node_modules/html-webpack-plugin/lib/compiler.js:341:38)
@entria/web:     at Array.some (<anonymous>)
@entria/web:     at isChildCompilerCacheOutdated (/home/matheus/projects/forks/entria-fullstack/node_modules/html-webpack-plugin/lib/compiler.js:340:59)
@entria/web:     at Object.hasOutDatedTemplateCache (/home/matheus/projects/forks/entria-fullstack/node_modules/html-webpack-plugin/lib/compiler.js:321:16)
@entria/web:     at compiler.hooks.thisCompilation.tap (/home/matheus/projects/forks/entria-fullstack/node_modules/html-webpack-plugin/index.js:132:25)
@entria/web:     at SyncHook.eval [as call] (eval at create (/home/matheus/projects/forks/entria-fullstack/node_modules/tapable/lib/HookCodeFactory.js:19:10), <anonymous>:7:1)
@entria/web:     at Compiler.newCompilation (/home/matheus/projects/forks/entria-fullstack/node_modules/webpack/lib/Compiler.js:526:30)
@entria/web:     at hooks.beforeCompile.callAsync.err (/home/matheus/projects/forks/entria-fullstack/node_modules/webpack/lib/Compiler.js:567:29)
@entria/web:     at AsyncSeriesHook.eval [as callAsync] (eval at create (/home/matheus/projects/forks/entria-fullstack/node_modules/tapable/lib/HookCodeFactory.js:32:10), <anonymous>:6:1)
@entria/web:     at Compiler.compile (/home/matheus/projects/forks/entria-fullstack/node_modules/webpack/lib/Compiler.js:562:28)

Feedback left here: jantimon/html-webpack-plugin#1129

sibelius · 2019-01-28T23:43:57Z

not ready yet

codecov-io · 2019-01-28T23:44:35Z

Codecov Report

❗ No coverage uploaded for pull request base (master@a78e9b7). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master      #46   +/-   ##
=========================================
  Coverage          ?   82.23%           
=========================================
  Files             ?       21           
  Lines             ?      197           
  Branches          ?       35           
=========================================
  Hits              ?      162           
  Misses            ?       27           
  Partials          ?        8

Impacted Files	Coverage Δ
packages/web/jest.setup.js	`100% <100%> (ø)`
packages/web/src/App.tsx	`100% <100%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a78e9b7...0923b81. Read the comment docs.

sibelius · 2019-01-29T12:54:05Z

packages/web/package.json

+    "@types/react-relay": "1.3.10",
+    "@types/rebass": "0.3.4",
+    "@types/styled-components": "4.1.6",
+    "@types/styled-system": "3.1.3",


I think we can move all @types to root package

Even if types are not "common"?

let them here then

sibelius · 2020-10-02T17:02:33Z

we can try again next week, tks

matheus1lva added 2 commits January 4, 2019 02:33

migration to webpack@next

c765736

revert changes

c3eaccb

matheus1lva requested a review from sibelius January 4, 2019 04:42

sibelius reviewed Jan 4, 2019

View reviewed changes

package.json Outdated Show resolved Hide resolved

jgcmarins reviewed Jan 4, 2019

View reviewed changes

packages/web/src/App.tsx Outdated Show resolved Hide resolved

matheus1lva added 2 commits January 5, 2019 00:10

move deps back to own packages and fix eslint errors

aacfae0

revert back frontend changes

0902b18

matheus1lva self-assigned this Jan 5, 2019

matheus1lva added the enhancement New feature or request label Jan 5, 2019

fix dependencies and paths

cb12eeb

miltoneiji reviewed Jan 5, 2019

View reviewed changes

packages/web/package.json Outdated Show resolved Hide resolved

matheus1lva added 2 commits January 5, 2019 02:06

remove forgotten comment

10df50b

remove noEmit

895ca8e

sibelius mentioned this pull request Jan 5, 2019

support webpack@5 webpack-contrib/mini-css-extract-plugin#330

Closed

sibelius mentioned this pull request Jan 5, 2019

TypeError: Cannot read property 'get' of undefined when used with webpack 5 jantimon/html-webpack-plugin#1129

Closed

feat(webpack): simplify webpack config, use html webpack plugin 4 bet…

5b1f000

…a5 to work nice with wp5

sibelius mentioned this pull request Jan 5, 2019

webpack 5 alpha feedback webpack/webpack#8537

Closed

19 tasks

fix globals problem

a29c18a

feat(merge): merge with master

0923b81

matheus1lva added 4 commits January 29, 2019 08:33

Merge branch 'master' into webpack/next

b770b9f

chore: fix conflict on yarn lock and package

8fd763e

chore: fix dependencies

93c98c3

chore(deps): fix type errors from relay

257c0fb

sibelius reviewed Jan 29, 2019

View reviewed changes

matheus1lva mentioned this pull request Jan 29, 2019

webpack package #55

Closed

sibelius closed this Oct 2, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Webpack@5 #46

[WIP] Webpack@5 #46

matheus1lva commented Jan 4, 2019 •

edited

Loading

sibelius commented Jan 4, 2019

sibelius commented Jan 4, 2019

matheus1lva commented Jan 5, 2019 •

edited

Loading

sibelius commented Jan 5, 2019

sibelius commented Jan 5, 2019

sibelius commented Jan 5, 2019

sibelius commented Jan 5, 2019

sibelius commented Jan 5, 2019

matheus1lva commented Jan 5, 2019

matheus1lva commented Jan 5, 2019

matheus1lva commented Jan 5, 2019 •

edited

Loading

matheus1lva commented Jan 7, 2019 •

edited

Loading

sibelius commented Jan 28, 2019

codecov-io commented Jan 28, 2019

sibelius Jan 29, 2019

matheus1lva Jan 29, 2019

sibelius Jan 29, 2019 •

edited

Loading

sibelius commented Oct 2, 2020 •

edited

Loading

[WIP] Webpack@5 #46

[WIP] Webpack@5 #46

Conversation

matheus1lva commented Jan 4, 2019 • edited Loading

sibelius commented Jan 4, 2019

sibelius commented Jan 4, 2019

matheus1lva commented Jan 5, 2019 • edited Loading

sibelius commented Jan 5, 2019

sibelius commented Jan 5, 2019

sibelius commented Jan 5, 2019

sibelius commented Jan 5, 2019

sibelius commented Jan 5, 2019

matheus1lva commented Jan 5, 2019

matheus1lva commented Jan 5, 2019

matheus1lva commented Jan 5, 2019 • edited Loading

matheus1lva commented Jan 7, 2019 • edited Loading

sibelius commented Jan 28, 2019

codecov-io commented Jan 28, 2019

Codecov Report

sibelius Jan 29, 2019

Choose a reason for hiding this comment

matheus1lva Jan 29, 2019

Choose a reason for hiding this comment

sibelius Jan 29, 2019 • edited Loading

Choose a reason for hiding this comment

sibelius commented Oct 2, 2020 • edited Loading

matheus1lva commented Jan 4, 2019 •

edited

Loading

matheus1lva commented Jan 5, 2019 •

edited

Loading

matheus1lva commented Jan 5, 2019 •

edited

Loading

matheus1lva commented Jan 7, 2019 •

edited

Loading

sibelius Jan 29, 2019 •

edited

Loading

sibelius commented Oct 2, 2020 •

edited

Loading