fix(urls): skip empty url() handling (#304)

webpack-contrib · Feb 15, 2018 · 64f12dc · 64f12dc
1 parent 91e0316
commit 64f12dc
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/lib/urls.js b/lib/urls.js
@@ -62,7 +62,7 @@ module.exports = function (css) {
 			.replace(/^'(.*)'$/, function(o, $1){ return $1; });
 
 		// already a full url? no change
-		if (/^(#|data:|http:\/\/|https:\/\/|file:\/\/\/)/i.test(unquotedOrigUrl)) {
+		if (/^(#|data:|http:\/\/|https:\/\/|file:\/\/\/|\s*$)/i.test(unquotedOrigUrl)) {
 		  return fullMatch;
 		}
 

diff --git a/test/fixUrls.test.js b/test/fixUrls.test.js
@@ -143,6 +143,17 @@ describe("fix urls tests", function() {
         assertUrl("body { background-image:url(#bg.jpg); }");
     });
 
+    // empty urls
+    it("Empty url should be skipped", function() {
+      assertUrl("body { background-image:url(); }");
+      assertUrl("body { background-image:url( ); }");
+      assertUrl("body { background-image:url(\n); }");
+      assertUrl("body { background-image:url(''); }");
+      assertUrl("body { background-image:url(' '); }");
+      assertUrl("body { background-image:url(\"\"); }");
+      assertUrl("body { background-image:url(\" \"); }");
+    });
+
     // rooted urls
     it("Rooted url", function() {
       assertUrl(