Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hot module replacement logic for lazy type #468

Merged
merged 1 commit into from
Apr 28, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/nodejs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,10 @@ jobs:
runs-on: ${{ matrix.os }}

steps:
- name: Setup Git
if: matrix.os == 'windows-latest'
run: git config --global core.autocrlf input

- uses: actions/checkout@v2

- name: Use Node.js ${{ matrix.node-version }}
Expand Down
14 changes: 7 additions & 7 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
"@webpack-contrib/eslint-config-webpack": "^3.0.0",
"babel-jest": "^25.4.0",
"cross-env": "^7.0.2",
"css-loader": "^3.5.2",
"css-loader": "^3.5.3",
"del": "^5.1.0",
"del-cli": "^3.0.0",
"es-check": "^5.1.0",
Expand All @@ -72,7 +72,7 @@
"memfs": "^3.1.2",
"npm-run-all": "^4.1.5",
"prettier": "^2.0.5",
"sass": "^1.26.3",
"sass": "^1.26.5",
"sass-loader": "^8.0.2",
"semver": "^7.3.2",
"standard-version": "^7.1.0",
Expand Down
32 changes: 16 additions & 16 deletions src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,15 +39,15 @@ if (module.hot) {
function() {
${
esModule
? `update(content);`
: `var newContent = require(${loaderUtils.stringifyRequest(
? 'update(content);'
: `content = require(${loaderUtils.stringifyRequest(
this,
`!!${request}`
)});

newContent = newContent.__esModule ? newContent.default : newContent;
content = content.__esModule ? content.default : content;

update(newContent);`
update(content);`
}
}
);
Expand Down Expand Up @@ -118,23 +118,23 @@ if (module.hot) {
if (update && refs > 0) {
update(content);
}`
: `var newContent = require(${loaderUtils.stringifyRequest(
: `content = require(${loaderUtils.stringifyRequest(
this,
`!!${request}`
)});

newContent = newContent.__esModule ? newContent.default : newContent;
content = content.__esModule ? content.default : content;

if (!isEqualLocals(oldLocals, newContent.locals)) {
if (!isEqualLocals(oldLocals, content.locals)) {
module.hot.invalidate();

return;
}

oldLocals = newContent.locals;
oldLocals = content.locals;

if (update && refs > 0) {
update(newContent);
update(content);
}`
}
}
Expand Down Expand Up @@ -230,26 +230,26 @@ if (module.hot) {
oldLocals = content.locals;

update(content);`
: `var newContent = require(${loaderUtils.stringifyRequest(
: `content = require(${loaderUtils.stringifyRequest(
this,
`!!${request}`
)});

newContent = newContent.__esModule ? newContent.default : newContent;
content = content.__esModule ? content.default : content;

if (typeof newContent === 'string') {
newContent = [[module.id, newContent, '']];
if (typeof content === 'string') {
content = [[module.id, content, '']];
}

if (!isEqualLocals(oldLocals, newContent.locals)) {
if (!isEqualLocals(oldLocals, content.locals)) {
module.hot.invalidate();

return;
}

oldLocals = newContent.locals;
oldLocals = content.locals;

update(newContent);`
update(content);`
}
}
)
Expand Down
4 changes: 4 additions & 0 deletions test/manual/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,10 @@ <h2>Modules</h2>
<div class="page-btn">BACKGROUND SHOULD BE CRIMSON</div>
</section>

<section id="toggle-section">
<h2>Toggle</h2>
</section>

<section>
<h2>Custom element</h2>
<custom-square l="100" c="red"></custom-square>
Expand Down
26 changes: 26 additions & 0 deletions test/manual/src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import one from './modules/one.module.css';
import two from './modules/two.module.css';
import toolbar from './modules/toolbar.module.css';
import page from './modules/page.module.css';
import toogle from './toogle.lazy.css';

console.log('___LOCALS___');
console.log(component);
Expand Down Expand Up @@ -114,3 +115,28 @@ const common1 = document.querySelector('.common');
common1.className = toolbar.common;
const pageBtn = document.querySelector('.page-btn');
pageBtn.className = page['page-btn'];

const button = document.createElement('button');

button.innerText = 'Toggle CSS';

let used = false;

button.addEventListener('click', () => {
if (!used) {
console.log('toggle on');
toogle.use();

used = true;
} else {
console.log('toggle off');

toogle.unuse();

used = false;
}
});

const toggleSection = document.getElementById('toggle-section');

toggleSection.appendChild(button);
3 changes: 3 additions & 0 deletions test/manual/src/toogle.lazy.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
#toggle-section {
background-color: red;
}