-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use better micromatch extglobs #216
fix: use better micromatch extglobs #216
Conversation
|
Codecov Report
@@ Coverage Diff @@
## master #216 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 125 125
Branches 25 25
=========================================
Hits 125 125
Continue to review full report at Codecov.
|
Thanks @bahmannejati |
Hi, I think this can be considered a breaking change, my builds break with Also the readme should be updated to reflect this change |
webpack-contrib#216 introduced a new default value for files option. This commit reflects the change
Include `.css` files and target `/app` Ref: webpack-contrib/stylelint-webpack-plugin#216
Include `.css` files and target `/app` Ref: webpack-contrib/stylelint-webpack-plugin#216
Include `.css` files and target `/app` Ref: webpack-contrib/stylelint-webpack-plugin#216
Hi @ricardogobbosouza! Could we please revert this and release it as a breaking change. An npm audit is breaking all our builds. Thanks! |
#216 introduced a new default value for files option. This commit reflects the change
This PR contains a:
Motivation / Use-Case
It seems that the default value for the
files
option has an issue.If the purpose of
**/*.s?(c|a)ss
is to match justscss
orsass
files so why we need?
afters
I think the
**/*.(s(c|a)ss|css)
is better for supportingcss
,scss
&sass
files.