fix: types for the extractComments option (#444)

webpack-contrib · Sep 3, 2021 · 14e5cbf · 14e5cbf
1 parent c314e33
commit 14e5cbf
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/src/index.js b/src/index.js
@@ -53,9 +53,9 @@ import { minify as minimize } from "./minify";
 
 /**
  * @typedef {Object} ExtractCommentsObject
- * @property {ExtractCommentsCondition} condition
- * @property {ExtractCommentsFilename} filename
- * @property {ExtractCommentsBanner} banner
+ * @property {ExtractCommentsCondition} [condition]
+ * @property {ExtractCommentsFilename} [filename]
+ * @property {ExtractCommentsBanner} [banner]
  */
 
 /**

diff --git a/types/index.d.ts b/types/index.d.ts
@@ -33,9 +33,9 @@ export type ExtractCommentsBanner =
   | boolean
   | ((commentsFile: string) => string);
 export type ExtractCommentsObject = {
-  condition: ExtractCommentsCondition;
-  filename: ExtractCommentsFilename;
-  banner: ExtractCommentsBanner;
+  condition?: ExtractCommentsCondition | undefined;
+  filename?: ExtractCommentsFilename | undefined;
+  banner?: ExtractCommentsBanner | undefined;
 };
 export type ExtractCommentsOptions =
   | ExtractCommentsCondition
@@ -129,9 +129,9 @@ export type DefinedDefaultMinimizerAndOptions<T> =
  */
 /**
  * @typedef {Object} ExtractCommentsObject
- * @property {ExtractCommentsCondition} condition
- * @property {ExtractCommentsFilename} filename
- * @property {ExtractCommentsBanner} banner
+ * @property {ExtractCommentsCondition} [condition]
+ * @property {ExtractCommentsFilename} [filename]
+ * @property {ExtractCommentsBanner} [banner]
  */
 /**
  * @typedef {ExtractCommentsCondition | ExtractCommentsObject} ExtractCommentsOptions