Terser v3.16.0 breaks terser-webpack-plugin

[pitops]

The latest terser update (released an hour ago) breaks this plugin.

• Operating System:
• Node Version: 10.12.0
• NPM Version: 6.4.1
• webpack Version: 4.29.0
• terser-webpack-plugin Version: 1.2.1

Expected Behavior

Terser to minify my code

Actual Behavior

ERROR in js/main.6e4faa1e7d31caf0fa3b.js from Terser
TypeError: Cannot read property 'minify' of undefined
    at minify (/<path>/node_modules/terser-webpack-plugin/dist/minify.js:175:23)

How Do We Reproduce?

Delete yarn.lock

Install terser-webpack-plugin and try to run a production build where the plugin is called

workaround

As a workaround for now if you use yarn you can add a resolution to a fixed terser version. Delete yarn.lock first and node_modules

Example (in your package.json)

"resolutions": {
  "terser": "3.14.1"
}

For npm try the suggestion by @odedi

[kurtinatlanta]

I added console logging locally and the _terser object is empty ({}) at the point where it's trying to do this:

  const {
    error,
    map,
    code,
    warnings
  } = _terser.default.minify({
    [file]: input
  }, terserOptions);

_terser.default is undefined and therefore it can't dereference _terser.default.minify.

I assume the terser folks must have changed something such that

var _terser = _interopRequireDefault(require("terser"));

no longer gets the right object.

[Xanngo]

I changed _terser.default.minify to _terser.minify and it works

[hutzleo]

https://github.com/rogeriochaves/npm-force-resolutions
for npm

[filipesilva]

terser/terser#254 should address this.

[3cp]

Even without any work from terser, you can fix the code in this repo, defensively support both terser 3.16 (esm) and old versions (commonjs).

// import terser from 'terser';
// change to
import {minify} from 'terser';

//... change terser.minify(...) to minify(...)

[vladimiry]

@huochunpeng the point is that terser made a breaking change without bumping the major version, but just v3.14.1 => v3.16.0. Besides worth taking into the account that it's not just terser-webpack-plugin depends on terser but many other libraries too.

[3cp]

@vladimiry you are right, I understand. I just offer a solution for this repo instead of waiting terser to fix the backward compatibility.

[greyscaled]

I changed _terser.default.minify to _terser.minify and it works

Thanks ❤️ , verified for me running npm run build with:

devDependencies": {
    ...,
    "@vue/cli-plugin-babel": "^3.4.0",
    "@vue/cli-service": "^3.4.0",
  }

[alexander-akait]

/cc @fabiosantoscode hopefully you add tests on this regressions, it is break webpack for many developers

[alasdairhurst]

@ksharlandjiev package-lock is generally quite good for applications but not libraries (since you won't be testing and building using the same dependencies that users of your library will end up with)

[vladimiry]

@ksharlandjiev package-lock is generally quite good for applications but not libraries (since you won't be testing and building using the same dependencies that users of your library will end up with)

Locking the dependencies is useful for libraries too as it makes the build process reproducible.

[kopax]

Locking the dependencies is not that useful for libraries. You rather want to see things break in your CI and be warned about it. If you must lock your dependency to a certain dependencies, this should be the way to go.

[sidag95]

Awesome @pitops the workaround works, thanks

[manniL]

terser/terser#251

Resolved

[afide1]

The latest terser update (released an hour ago) breaks this plugin.

• Operating System:
• Node Version: 10.12.0
• NPM Version: 6.4.1
• webpack Version: 4.29.0
• terser-webpack-plugin Version: 1.2.1

Expected Behavior

Terser to minify my code

Actual Behavior

ERROR in js/main.6e4faa1e7d31caf0fa3b.js from Terser
TypeError: Cannot read property 'minify' of undefined
    at minify (/<path>/node_modules/terser-webpack-plugin/dist/minify.js:175:23)

How Do We Reproduce?

Delete yarn.lock

Install terser-webpack-plugin and try to run a production build where the plugin is called

workaround

As a workaround for now if you use yarn you can add a resolution to a fixed terser version. Delete yarn.lock first and node_modules

Example (in your package.json)

"resolutions": {
  "terser": "3.14.1"
}

For npm try the suggestion by @odedi

"Thank you!"

[pitops]

@afide1 Hey, its been fixed, all you need to do is update terser-webpack-plugin to v1.2.2 +