Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable viewer websocket connection if mode is static #215

Merged
merged 1 commit into from
Oct 16, 2018
Merged

Disable viewer websocket connection if mode is static #215

merged 1 commit into from
Oct 16, 2018
+8 −3

Conversation

sebastianhaeni
Copy link
Contributor

Resolves #195

@jsf-clabot
Copy link

jsf-clabot commented Oct 16, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@valscion
Copy link
Member

Looks good to me. What do you think, @th0r?

@valscion valscion requested a review from th0r October 16, 2018 10:07
@th0r
Copy link
Collaborator

th0r commented Oct 16, 2018

Looks good. Thanks @sebastianhaeni!
@valscion could you publish a new version with this change because I don't have time right now?

@th0r th0r merged commit 5be7049 into webpack-contrib:master Oct 16, 2018
@valscion
Copy link
Member

@valscion could you publish a new version with this change because I don't have time right now?

Will do 👍

valscion added a commit that referenced this pull request Oct 16, 2018
@valscion
Add changelog entry for #215
aeaa843
@valscion
Copy link
Member

Published v3.0.3 with this change 🎉

@gaokun gaokun mentioned this pull request Sep 20, 2019
Closed
This was referenced Mar 11, 2021
Open
Merged
Open
Open
Open
Open
Merged
Open
Open
Open
Open
Open
Open
Open
Merged
Open
Open
@dependabot dependabot bot mentioned this pull request Mar 18, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valscion valscion valscion approved these changes

@th0r th0r th0r approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sebastianhaeni @jsf-clabot @valscion @th0r