-
-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Travis with GitHub actions as CI #402
Conversation
Otherwise the actions are ran only when a pull request is open.
I disabled the |
I don't know — I can check if that's possible when I have the time |
It now looks like so: It seems quite simple to change the name to whatever we want as can be seen by fdb5a0e — feel free to make a direct code suggestion to this PR if you have a better wording in mind |
Co-authored-by: Yuriy Grunin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!
Do we need the branch protections? I'm not sure if they're necessary — a red CI should be enough for us to avoid merging pull requests. The CLA-check of course stays as a required status check. |
I don't even know what is that =) |
Ah, it's this one: So one can't merge a pull request (unless they're an admin and admin overrule is allowed) if a required status check is not successful. We could configure some or all of the GitHub Actions status checks to be required to be successful to allow merging via https://github.com/webpack-contrib/webpack-bundle-analyzer/settings/branches, from here: |
Ah, ok, thanks for the explanation. I don't think we need it. |
Yeah I think the same, let's keep it as it is now 👍 |
Resolves #400