Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove is-plain-object #627

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

SukkaW
Copy link
Contributor

@SukkaW SukkaW commented Apr 7, 2024

The PR removes a dependency is-plain-object, further reducing the installation size.

Ref #505 #609 #612

Turns out that the return value of analyzer.getViewerData() is always an array (from Object.entries), we can safely remove the is-plain-object guard.

Copy link
Member

@valscion valscion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@valscion valscion merged commit c531af9 into webpack-contrib:master Apr 9, 2024
6 checks passed
@valscion
Copy link
Member

This has now been released as part of v4.10.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants