Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow default condition to be anywhere #423

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

scagood
Copy link
Contributor

@scagood scagood commented May 31, 2024

Description

This aligns the "default" condition behaviour with Node.Js. Specifically, this allows the "default" condition to be found anywhere in the "exports" without throwing an error.

Related Issues:


fixes #421

Copy link

linux-foundation-easycla bot commented May 31, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@scagood scagood changed the title feat!: allow default condition to be anywhere feat: allow default condition to be anywhere May 31, 2024
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.99%. Comparing base (283136c) to head (1213f32).
Report is 23 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #423      +/-   ##
==========================================
- Coverage   92.50%   91.99%   -0.51%     
==========================================
  Files          44       44              
  Lines        2067     2123      +56     
  Branches      603      645      +42     
==========================================
+ Hits         1912     1953      +41     
- Misses        125      138      +13     
- Partials       30       32       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexander-akait alexander-akait merged commit 5994a0f into webpack:main Jun 4, 2024
24 of 25 checks passed
@scagood scagood deleted the issue-421 branch June 4, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore Default condition should be last one
3 participants