Add deprecation warning to parseQuery #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sokra
requested changes
Feb 9, 2017
index.js
Outdated
| "loaderUtils.parseQuery() just received a value type of " + typeof query + | ||
| " which can be problematic, see https://github.com/webpack/loader-utils/issues/56" + os.EOL + | ||
| "parseQuery() will be replaced with getOptions() in the next major version of loader-utils."))(), | ||
| query; |
There was a problem hiding this comment.
Does it really have to be formatted this way??
The , operator is difficult to understand and I think it's better to use { ...; ...; } here.
There was a problem hiding this comment.
Doesn't using deprecate this way will report the message on every call instead of only once?
There was a problem hiding this comment.
You're right with both. I've changed it
jhnns
force-pushed
the
add/parse-query-warning
branch
from
2c4728b
to
9a91ae0
Compare
This deprecation warning is intended to alarm loader authors that passing an object to parseQuery and then modifying it might lead to unintended behavior. #56
jhnns
force-pushed
the
add/parse-query-warning
branch
from
9a91ae0
to
c7f7a52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deprecation warning is intended to alarm loader authors that passing an object to parseQuery and then modifying it might lead to unintended behavior.
#56