-
-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request]: Let's rework some of the main scaffolding layout #709
Comments
Are we going to track these feats in this issue? I would like to handle some of them. |
Probably. If there's no PR's open, take one down @EvsChen , thanks! |
I guess I'll handle the config naming first. |
I've already submitted a PR for that. Other than that, up for grabs |
Working on 1 - Generate webpack config in the root of the project. 😄 |
migrated to use find-up sync to determine project root, removed additional packages ISSUES CLOSED: webpack#709
I have a question, what's the workflow when defaults are used? (Point 2) |
Then we run the init generator |
Cool! Working on point 2 - Run init generator when defaults are used, thanks @evenstensberg! 😄 |
I think I have an approach in mind, will be sending a WIP soon. 👍 |
This issue had no activity for at least half a year. It's subject to automatic issue closing if there is no activity in the next 15 days. |
This issue had no activity for at least half a year. It's subject to automatic issue closing if there is no activity in the next 15 days. |
Issue was closed because of inactivity. If you think this is still a valid issue, please file a new issue with additional information. |
Describe the solution you'd like
Let's rework how development and production configs are laid out.
webpack.config.js
webpack-merge
not Object.assign--env.mode development
--env.mode production
to determine whether or not production or development modes are used.webpack.config.js
file, or the common config.dev
and production script is calledprod
.webpack
is generated so users can runnpm run webpack
. This will be used inside ofdev
andprod
scripts for composition sakes.Hopefully all of this is clear and I added them in checkbox format. These ideas I've created based on positive feedback I've received from my workshops and talks.
Since all this code is JavaScript i would understand that there are many opinions on how configs are formatted but I would like to go this direction because I believe it is just easier to maintain this way.
If you look at my repo: https://github.com/TheLarkInn/webpack-workshop-2018/tree/feature/19-sm-css-code-split
This shows you a fully fleshed out example with many features, integrations, etc and hopefully we can follow this style (even presets which I can document in a separate issue).
The text was updated successfully, but these errors were encountered: