Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc(dep): add webpack 4 as peer dependency #297

Merged
merged 1 commit into from
Mar 1, 2018

Conversation

dhruvdutt
Copy link
Member

@dhruvdutt dhruvdutt commented Feb 28, 2018

What kind of change does this PR introduce?
Dependencies definition, Fixes #295

Summary
Adds webpack 4 as a peer dependency

Does this PR introduce a breaking change?
No

Other information
Followed same versioning as webpack-dev-server

@webpack-bot
Copy link

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@evenstensberg evenstensberg merged commit a99194c into webpack:master Mar 1, 2018
@ematipico
Copy link
Contributor

Why a beta version has been added as peer dependency?

@dhruvdutt
Copy link
Member Author

@ematipico

Followed same versioning as webpack-dev-server

Are there any features that came after beta which are required by cli?

@evenstensberg
Copy link
Member

This is correct, latest webpack should be the one we're targeting

@ematipico
Copy link
Contributor

Alpha and beta are releases that talks by themselves, they are still not officials. I think the package.json should state webpack: ^4.0.0 as peer dep.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants