Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): updated tests file names #324

Merged
merged 1 commit into from
Mar 10, 2018
Merged

chore(test): updated tests file names #324

merged 1 commit into from
Mar 10, 2018

Conversation

ematipico
Copy link
Contributor

What kind of change does this PR introduce?
Chore, renamed test files

Did you add tests for your changes?
No

If relevant, did you update the documentation?
No

Summary
Changed test files from *.spec.js to *.test.js

Does this PR introduce a breaking change?
It shouldn't, although locally I had some failing test (not these ones) and I couldn't understand why

Other information

@webpack-bot
Copy link

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

Copy link
Member

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually we approve both, but okay 👍

Copy link
Member

@dhruvdutt dhruvdutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also clean *.spec.js from .npmignore?

@ematipico
Copy link
Contributor Author

@ev1stensberg do we? All the file names are *.test.js, I thought we were consistent in that way

@ematipico
Copy link
Contributor Author

@dhruvdutt why do I have to remove *.spec.js? I don't get

@dhruvdutt
Copy link
Member

Because there would be no files with spec.js extension.

@ematipico
Copy link
Contributor Author

I can do it! But first I'd like to know @ev1stensberg point of you.

@evenstensberg
Copy link
Member

Keep .spec, it's not like it's illegal to use another convention 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants