Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README to remove inconsistent CLI messaging #328

Merged
merged 1 commit into from
Mar 10, 2018
Merged

Update README to remove inconsistent CLI messaging #328

merged 1 commit into from
Mar 10, 2018

Conversation

bitpshr
Copy link
Member

@bitpshr bitpshr commented Mar 9, 2018

What kind of change does this PR introduce?
Documentation

Did you add tests for your changes?
N/A

If relevant, did you update the documentation?
Yes

Summary
This PR updates the README to remove inconsistent messaging about the old webpack CLI. See #327.

Does this PR introduce a breaking change?
No

Other information
Fixes #327

@jsf-clabot
Copy link

jsf-clabot commented Mar 9, 2018

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@dhruvdutt dhruvdutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Welcome to webpack. 🎉

Copy link
Member

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit: , thanks! 💙

@bitpshr
Copy link
Member Author

bitpshr commented Mar 9, 2018

Happy to help, thanks for the quick review.

@dhruvdutt
Copy link
Member

@bitpshr We use commitlint. Use git cz for an iteractive commit or use one of these.

@webpack-bot
Copy link

@bitpshr Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@ev1stensberg Please review the new changes.

@webpack-bot
Copy link

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@evenstensberg
Copy link
Member

Sweet Beans, thanks for the PR @bitpshr !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants