Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc(cz): fix type description #339

Merged
merged 2 commits into from
Mar 12, 2018
Merged

misc(cz): fix type description #339

merged 2 commits into from
Mar 12, 2018

Conversation

dhruvdutt
Copy link
Member

@dhruvdutt dhruvdutt commented Mar 11, 2018

Summary

  • cz-config
    • fix type description
    • reorder
    • clean deps type

image

@webpack-bot
Copy link

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

Copy link
Contributor

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, you might want to add a comment reminding to keep the entries in alphabetic oreder

Copy link
Member

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deps are chore, no need for that

@webpack-bot
Copy link

@dhruvdutt Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@ev1stensberg Please review the new changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants