Feature/package test ts #584
Conversation
webpack-bot
added
PR: conflict
PR: unreviewed
PR: CI-not-ok
and removed
PR: conflict
labels
.prettierrc
Outdated
| @@ -0,0 +1,3 @@ | |||
| { | |||
There was a problem hiding this comment.
we can supply this cli wise
There was a problem hiding this comment.
What do you mean?
| @@ -0,0 +1,25 @@ | |||
| // Jest Snapshot v1, https://goo.gl/fbAQLP | |||
|
|
|||
| exports[`info should return the information of the enviroment 1`] = ` | |||
There was a problem hiding this comment.
use regular js for this, no need for snapshot against pure js objects
packages/info/index.ts
Outdated
| npmGlobalPackages: ["webpack", "webpack-cli"], | ||
| npmPackages: "*webpack*", | ||
| }), | ||
| await envinfo.run(information()), |
There was a problem hiding this comment.
does envinfo write to stdout by default?
There was a problem hiding this comment.
Automatically, it doesn't, otherwise the stdout wouldn't be there
packages/info/package.json
Outdated
| "build": "tsc", | ||
| "watch": "npm run build && tsc -w" | ||
| } | ||
| "name": "@webpack-cli/info", |
There was a problem hiding this comment.
Trying to figure this out. In theory it should follow .editorconfig
webpack-bot
added
PR: reviewed-changes-requested
and removed
PR: unreviewed
PR: reviewed-changes-requested
labels
|
@ematipico Thanks for your update. I labeled the Pull Request so reviewers will review it again. @ev1stensberg Please review the new changes. |
tsconfig.json
Outdated
| "packages/*/node_modules/**" | ||
| ] | ||
| "include": ["packages/**/*.ts"], | ||
| "exclude": ["node_modules/**", "packages/*/node_modules/**", "packages/*/__tests__/**"] |
There was a problem hiding this comment.
We don't want to build the test files, so for now I added this match to exclude them
|
Looks like commitlint is complaining due to the rebase. Can we skip that for now? We can squash with a fair commit |
|
If the PR is approved we can do a squash |
package.json
Outdated
| @@ -120,8 +114,6 @@ | |||
| "codecov": "^3.1.0", | |||
| "commitizen": "^2.10.1", | |||
| "conventional-changelog-cli": "^2.0.5", | |||
| "conventional-changelog-lint-config-cz": "^0.3.0", | |||
There was a problem hiding this comment.
This package has been archived
There was a problem hiding this comment.
Why was it archived, any idea? I can't find anything on their readme.
There was a problem hiding this comment.
It now can be done without that package
package.json
Outdated
| @@ -86,14 +87,7 @@ | |||
| "maxSize": "5.32 kB" | |||
| } | |||
| ], | |||
| "config": { | |||
There was a problem hiding this comment.
Due to archived packaged, I had to remove this configuration
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
|
Commit lint finally fixed :) |
What kind of change does this PR introduce?
First typescript test
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
No
Summary
Added first typescript test, really small
Does this PR introduce a breaking change?
No
Other information