Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added await in order to resolve the pending promise #948

Merged
merged 1 commit into from
Jun 16, 2019
Merged

chore: added await in order to resolve the pending promise #948

merged 1 commit into from
Jun 16, 2019

Conversation

anikethsaha
Copy link
Member

What kind of change does this PR introduce?
bugfix/refactoring

Did you add tests for your changes?
NA

If relevant, did you update the documentation?
NA

Summary
Added await in order to resolve the pending promise which was resulting in prompting error for 3rd question in init command

Does this PR introduce a breaking change?
NA

Other information
NA

@webpack-bot
Copy link

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

Copy link
Member

@anshumanv anshumanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bad rebase? I see a lot of unrelated commits

@anikethsaha
Copy link
Member Author

anikethsaha commented Jun 13, 2019

yeah, messed up the rebasing. trying to fix it. 👍

PS: Finally done fixing the rebasing.
@anshumanv @evenstensberg PTAL

@ematipico ematipico merged commit 6015bad into webpack:master Jun 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants