fix: prevent open 0.0.0.0 in browser due windows problems

webpack · Mar 28, 2023 · 04e74f2 · 04e74f2
1 parent 8850b18
commit 04e74f2
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/lib/Server.js b/lib/Server.js
@@ -2893,7 +2893,11 @@ class Server {
       }
 
       if (/** @type {NormalizedOpen[]} */ (this.options.open).length > 0) {
-        const openTarget = prettyPrintURL(this.options.host || "localhost");
+        const openTarget = prettyPrintURL(
+          !this.options.host || this.options.host === "0.0.0.0"
+            ? "localhost"
+            : this.options.host
+        );
 
         this.openBrowser(openTarget);
       }

diff --git a/test/server/open-option.test.js b/test/server/open-option.test.js
@@ -99,7 +99,7 @@ describe('"open" option', () => {
     });
   });
 
-  it("should work with '0.0.0.0' host", async () => {
+  it("should work with '0.0.0.0' host but open localhost", async () => {
     const host = "0.0.0.0";
 
     const server = new Server(
@@ -114,7 +114,7 @@ describe('"open" option', () => {
     await server.start();
     await server.stop();
 
-    expect(open).toHaveBeenCalledWith(`http://${host}:${port}/`, {
+    expect(open).toHaveBeenCalledWith(`http://localhost:${port}/`, {
       wait: false,
     });
   });