Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: types #5057

Merged
merged 1 commit into from
Feb 16, 2024
Merged

fix: types #5057

merged 1 commit into from
Feb 16, 2024

Conversation

alexander-akait
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

No need

Motivation / Use-Case

fixes #5054

Breaking Changes

No

Additional Info

No

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0c4c6b7) 89.94% compared to head (54ea59e) 90.05%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5057      +/-   ##
==========================================
+ Coverage   89.94%   90.05%   +0.10%     
==========================================
  Files          15       15              
  Lines        1581     1578       -3     
  Branches      601      601              
==========================================
- Hits         1422     1421       -1     
+ Misses        145      143       -2     
  Partials       14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexander-akait alexander-akait merged commit da2c24d into master Feb 16, 2024
29 of 41 checks passed
@alexander-akait alexander-akait deleted the fix-types branch February 16, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Types in lib/Server referring to non-existing Request_1 and Response_1 interfaces
1 participant