Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'events' dependency #8494

Merged
merged 1 commit into from
Dec 14, 2018
Merged

Add 'events' dependency #8494

merged 1 commit into from
Dec 14, 2018

Conversation

ooflorent
Copy link
Member

webpack/hot/emitter.js requires events.
This package used to be polyfilled automatically.
Now it requires the dependency to be manually installed.

What kind of change does this PR introduce?

bugfix

Did you add tests for your changes?

no

Does this PR introduce a breaking change?

no

What needs to be documented once your changes are merged?

nothing

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This need to be documented (issue in webpack/webpack.js.org will be filed when merged)

@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@sokra sokra merged commit d2083b9 into next Dec 14, 2018
@sokra sokra deleted the fix/hmr_client branch December 14, 2018 20:33
@sokra
Copy link
Member

sokra commented Dec 14, 2018

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants