-
-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package.json files having the same name property results in error even when added to ignoreWorkspaces #373
Comments
Here is the full error message and stack trace:
|
Right. I guess was confused, because just the other day I implemented the feature, but tested against workspaces not read through |
Since workspaces can also be ignored in the package manager config itself, and #374 itself is also closed, closing this one. |
@webpro I get the error even if I explicitly ignore the
|
I opened a PR to add an Angular adapter to TanStack query. Tried running Knip on the PR branch but get this error:
Reason being that an Angular package that is built with ng-packagr has a 'source' package.json and in the build directory the one that will be published. So you end up with two package.json files having the same name. This is easily fixable by:
I tested this on my machine and it fixes the error, will submit a PR.
The text was updated successfully, but these errors were encountered: