Fix RN peer dependency version #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@markwilcox can you also bump Thanks! |
|
Yes, happy to, I’ll update the PR in the morning.
…On Thu, Feb 16, 2023, at 5:32 PM, Bogdan Pop wrote:
@markwilcox <https://github.com/markwilcox> can you also bump `"version": "2.0.12"` to 2.0.13 in your PR so it's easier to merge & release?
Thanks!
—
Reply to this email directly, view it on GitHub <#97 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHPCFF5VSKT7J3AZKC23ZTWXZQBZANCNFSM6AAAAAAU6OSIWY>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
@webraptor The version is updated now. Thanks! |
|
released on npm 2.0.13. thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a ^ on the version only allows updates to everything below the first non-zero number. So this only lets you use the package with react-native 0.49.x. Changing to >= lets you use it with any version. I assume that's why there are 449 forks because it appears to still work with latest react-native versions.