Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization workflow improvements #1416

Closed
3 of 4 tasks
emma-sg opened this issue Nov 29, 2023 · 6 comments · Fixed by #2089
Closed
3 of 4 tasks

Localization workflow improvements #1416

emma-sg opened this issue Nov 29, 2023 · 6 comments · Fixed by #2089
Assignees
Labels
front end Requires front end dev work investigation Research and/or prototyping before dev work ops/deployment Related to deployment of Browsertrix Cloud tooling Tooling and developer experience work

Comments

@emma-sg
Copy link
Member

emma-sg commented Nov 29, 2023

  • CI: Ensure generated files are up-to-date
  • Local dev: Generate localization files in precommit hook?
  • [ ] Linting: Ensure localization strings don't have too much HTML in them
  • [ ] Linting: Ensure there are no non-localized string in HTML templates
  • Integrate Weblate
  • Extract strings in pull request action Localization workflow improvements #1416
@emma-sg emma-sg added front end Requires front end dev work ops/deployment Related to deployment of Browsertrix Cloud investigation Research and/or prototyping before dev work labels Nov 29, 2023
@SuaYoo
Copy link
Member

SuaYoo commented Dec 4, 2023

@ikreymer to investigate setting up weblate

@SuaYoo
Copy link
Member

SuaYoo commented Sep 9, 2024

@ikreymer to look into deploying weblate with k8s https://docs.weblate.org/en/latest/admin/install/kubernetes.html

@SuaYoo
Copy link
Member

SuaYoo commented Sep 10, 2024

Linting: Ensure there are no non-localized string in HTML templates

@emma-sg I didn't address this in #2069 but I think it's okay to start with a manual internal QA pass after translating the first language. I didn't see any existing tools that we can leverage, asked the Lit Discord channel as well.

@SuaYoo
Copy link
Member

SuaYoo commented Sep 11, 2024

From #2072 it looks like we'll need to format our extracted strings XML file to match weblate's XML format (see WeblateOrg/weblate#9096)

SuaYoo added a commit that referenced this issue Sep 11, 2024
Formats XLIFF file to match Weblate per
#1416 (comment)
@ikreymer
Copy link
Member

Investigate Weblate hosting pricing / self-hosting

@SuaYoo
Copy link
Member

SuaYoo commented Sep 23, 2024

@ikreymer I removed Make final decision on hosted vs self-hosted Weblate from marking this issue as complete since it focuses on localization workflow improvements, we could create a separate issue for following up with the libre trial if needed.

@SuaYoo SuaYoo added the tooling Tooling and developer experience work label Sep 23, 2024
@SuaYoo SuaYoo moved this from Implementing to In Review in Webrecorder Projects Sep 23, 2024
@vnznznz vnznznz removed their assignment Sep 24, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done! in Webrecorder Projects Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front end Requires front end dev work investigation Research and/or prototyping before dev work ops/deployment Related to deployment of Browsertrix Cloud tooling Tooling and developer experience work
Projects
Status: Done!
Development

Successfully merging a pull request may close this issue.

4 participants