Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show thumbnail screenshots in pages list #199

Closed
3 of 4 tasks
Shrinks99 opened this issue Jul 31, 2023 · 3 comments · Fixed by #221
Closed
3 of 4 tasks

Show thumbnail screenshots in pages list #199

Shrinks99 opened this issue Jul 31, 2023 · 3 comments · Fixed by #221
Assignees
@SuaYoo @Shrinks99
Labels
enhancement New feature or request
Milestone
ReplayWeb.Page Em...

Comments

@Shrinks99
Copy link
Member

Shrinks99 commented Jul 31, 2023 •
edited by SuaYoo
Loading

Context

We have thumbnails now and should use them!

Requirements

  • Users can see thumbnails for each page in the pages list to the right of the title and URL if thumbnails are available in at least one of the WACZ files loaded.

Mockups

Thumbnails_1

Todo

  • Mockups
  • Enable thumbnails during crawling
  • WACZ spec
  • UI changes
@Shrinks99 Shrinks99 added the enhancement New feature or request label Jul 31, 2023
@Shrinks99 Shrinks99 self-assigned this Jul 31, 2023
@matteocargnelutti
Copy link
Collaborator

matteocargnelutti commented Jul 31, 2023 •
edited
Loading

We have thumbnails now and should use them!

Oh cool! Is there some place I can read about how that feature is going to work / works in pages.jsonl? Thanks :)

@Shrinks99
Copy link
Member Author

@matteocargnelutti Not yet but once this is done hopefully yes!

We're still working on these tools ourselves! :)

@SuaYoo SuaYoo mentioned this issue Aug 29, 2023
Merged
@SuaYoo SuaYoo linked a pull request Sep 5, 2023 that will close this issue
Show page thumbnails in pages list #221
Merged
@SuaYoo SuaYoo added this to the ReplayWeb.Page v2.0.0 milestone Sep 5, 2023
@Shrinks99
Copy link
Member Author

Shrinks99 commented Sep 7, 2023 •
edited
Loading

Looks closed to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SuaYoo SuaYoo

@Shrinks99 Shrinks99

Labels
enhancement New feature or request
Projects
Webrecorder Projects
Status: Done!
Milestone
ReplayWeb.Page Embed v2.0.0
Development

Successfully merging a pull request may close this issue.

Show page thumbnails in pages list webrecorder/replayweb.page
3 participants
@matteocargnelutti @SuaYoo @Shrinks99