Show page thumbnails in pages list #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuaYoo
force-pushed
the
page-thumbnails
branch
from
aca8c8d
to
085e0b2
Compare
SuaYoo
force-pushed
the
page-thumbnails
branch
from
085e0b2
to
a031c66
Compare
SuaYoo
force-pushed
the
page-thumbnails
branch
from
94fe123
to
3f6eef8
Compare
SuaYoo
force-pushed
the
page-thumbnails
branch
from
3f6eef8
to
deaf69f
Compare
4 tasks
ikreymer
approved these changes
Sep 5, 2023
|
Looks great! |
SuaYoo
added a commit
that referenced
this pull request
Sep 6, 2023
* convert pages / pageentry to ts * render page icon * adjust for smaller screen * show favicon even if thumbnail exists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #199
Changes
pageentryandpagesto typescriptTesting
a. Manually crawl pages with AWP extension
b. Load file in local RWP. Verify favicons are shown
Follow-ups
If none of the pages in a list has a thumbnail or favicon, the page list shows an empty column. Could be addressed in a hacky way, but it'd be preferred to add thumbnail metadata to the wacz JSON, so that the
pagescomponent can hide the column altogether if there are no thumbnails. Alternatively, we could show a nicely designed placeholder image.Screenshots
Home page:
With date query:
Sidebar:
Sidebar with date query:
