Reasonably Scoped Branding Update #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shrinks99
changed the title
Adds ~assets directory, duped the setup in Browsertrix
- Accessibility improvements
- Changes the theme colour to be flush with the new white application bar
- Update webmanifest to use the new icons, moved to the directory on build
- Move embed receipt icons to src/assets/icons - In line with Browsertrix' organization scheme - Adds the new logo assets - Removes globe icon
- Replaces fa-icon with SVG logo embedded as an inline data URL in an img tag - Adds alt text to logo - Changes paragraph tag to div
- appLogo is no longer used in the embed receipt
- Simplifies how this is imported
ikreymer
force-pushed
the
well-scoped-branding-update
branch
from
9ed3dd5
to
82b19ac
Compare
Has mixed results across browsers, but overall an improvement. Dragging will now always copy the link at least!
update paths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now with 99% fewer icon changes!
This can be merged into
docs-mkdocs-switchordev-2.0.0, neither of which should conflict with2.0-ux-changes.Closes #291
Changes
/src/assetsin organized folders (Mirrors Browsertrix folder organization and naming)import: varName from ~assets/assetpathapp wide!svg-inline-loader, favicons are copied to/siteon app buildindex.htmlpage for ReplayWeb.page andembed.htmlexample pagerenderErrorReport()in swmanager.ts in favour of additional import statementsScreenshots