Reproduction of excessive tokio polling

With this change the reflect example will demonstrate excessive polling in the operations task despite not being woken.
webrtc-rs · Sep 6, 2022 · 5d05b88 · 5d05b88
1 parent b43e05b
commit 5d05b88
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 10 deletions.
diff --git a/examples/Cargo.toml b/examples/Cargo.toml
@@ -16,8 +16,8 @@ repository = "https://github.com/webrtc-rs/examples"
 
 [dev-dependencies]
 webrtc = { path = "../webrtc" }
-
-tokio = { version = "1.15", features = ["full"] }
+console-subscriber = { version = "<=0.1.7" }
+tokio = { version = "1.15", features = ["full", "tracing"] }
 env_logger = "0.9"
 clap = "3.0"
 hyper = { version = "0.14", features = ["full"] }

diff --git a/examples/examples/reflect/reflect.rs b/examples/examples/reflect/reflect.rs
@@ -81,7 +81,7 @@ async fn main() -> Result<()> {
             .filter(None, log::LevelFilter::Trace)
             .init();
     }
-
+    console_subscriber::init();
     // Everything below is the WebRTC-rs API! Thanks for using it ❤️.
 
     // Create a MediaEngine object to configure the supported codec

diff --git a/webrtc/src/peer_connection/operation/mod.rs b/webrtc/src/peer_connection/operation/mod.rs
@@ -116,16 +116,19 @@ impl Operations {
                 _ = close_rx.recv() => {
                     break;
                 }
-                result = ops_rx.recv() => {
-                    if let Some(mut f) = result {
-                        length.fetch_sub(1, Ordering::SeqCst);
-                        if f.0().await {
-                            // Requeue this operation
-                            let _ = Operations::enqueue_inner(f, &ops_tx, &length);
-                        }
+                Some(mut f) = ops_rx.recv() => {
+                    length.fetch_sub(1, Ordering::SeqCst);
+                    let op = format!("{:?}", f);
+                    log::info!("Started operation {}", op);
+                    if f.0().await {
+                        // Requeue this operation
+                        log::info!("Re-queued operation {}", op);
+                        let _ = Operations::enqueue_inner(f, &ops_tx, &length);
                     }
+                    log::info!("Done with operation {}", op);
                 }
             }
+            log::info!("Operation loop spun");
         }
     }