Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sctp] Include buffer size in ErrShortBuffer #456

Merged
merged 3 commits into from
Jun 12, 2023
Merged

Conversation

melekes
Copy link
Contributor

@melekes melekes commented Jun 12, 2023

Refs #273

@melekes melekes self-assigned this Jun 12, 2023
@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.02 ⚠️

Comparison is base (8168625) 61.50% compared to head (3cae751) 61.49%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #456      +/-   ##
==========================================
- Coverage   61.50%   61.49%   -0.02%     
==========================================
  Files         537      537              
  Lines       49505    49506       +1     
  Branches    12331    12331              
==========================================
- Hits        30447    30442       -5     
- Misses       9875     9882       +7     
+ Partials     9183     9182       -1     
Impacted Files Coverage Δ
sctp/src/association/association_test.rs 59.78% <0.00%> (ø)
sctp/src/queue/queue_test.rs 65.00% <0.00%> (ø)
sctp/src/error.rs 46.15% <100.00%> (+4.48%) ⬆️
sctp/src/queue/reassembly_queue.rs 92.13% <100.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@k0nserv
Copy link
Member

k0nserv commented Jun 12, 2023

I'm not active in this project anymore @melekes.

Maybe @rainliu or @yngrtc can help

@yngrtc yngrtc merged commit c472e6d into master Jun 12, 2023
@melekes melekes deleted the anton/273-partial-read-2 branch June 13, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants