Skip to content

Commit

Permalink
Condition frame pacing on min/max playout delay
Browse files Browse the repository at this point in the history
As a first step we only want to enable frame pacing for the case
where min playout delay == 0 and max playout delay > 0.

Bug: chromium:1237402, chromium:1239469
Change-Id: Icf9641db7566083d0279135efa8618e435d881eb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/228640
Commit-Queue: Johannes Kron <[email protected]>
Reviewed-by: Ilya Nikolaevskiy <[email protected]>
Cr-Commit-Position: refs/heads/master@{#34752}
  • Loading branch information
Johannes Kron authored and WebRTC LUCI CQ committed Aug 13, 2021
1 parent edfaaef commit b2745ba
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion modules/video_coding/timing.cc
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,8 @@ int64_t VCMTiming::MaxWaitingTime(int64_t render_time_ms,
bool too_many_frames_queued) const {
MutexLock lock(&mutex_);

if (render_time_ms == 0 && zero_playout_delay_min_pacing_->us() > 0) {
if (render_time_ms == 0 && zero_playout_delay_min_pacing_->us() > 0 &&
min_playout_delay_ms_ == 0 && max_playout_delay_ms_ > 0) {
// `render_time_ms` == 0 indicates that the frame should be decoded and
// rendered as soon as possible. However, the decoder can be choked if too
// many frames are sent at once. Therefore, limit the interframe delay to
Expand Down

0 comments on commit b2745ba

Please sign in to comment.