Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correctly map selected layers to simulcast layers #134

Open
wants to merge 2 commits into
base: m125_release
Choose a base branch
from
Open

fix: correctly map selected layers to simulcast layers #134

wants to merge 2 commits into from

Commits on Jul 15, 2024

  1. fix: correctly map selected layers to simulcast layers 

    this partly fixes webrtc-sdk#133.
Quick summary:
- on lower resolutions, simulcast only sends 2 (or even 1) layer.
- The layers are ordered from low to high resolution (downscale factors 4, 2, 1)
- previously, when only sending 2 layers (factors 2, 1), the layer with factor 2
  was mapped to the layer with factor 4, i.e. scaled down again)
- with this patch, the layers are mapped to the correct factor and not scaled
  down again
    @holzgeist
    holzgeist committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    e509fed View commit details
    Browse the repository at this point in the history

  2. fix: properly set mapping in case of 3 layers 

    encoder_config.simulcast_layers.size() is always >= layers.size(),
otherwise it not have worked before, so get rid of the (erronous) max
    @holzgeist
    holzgeist committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    021da3c View commit details
    Browse the repository at this point in the history