Use UIInterfaceOrientation instead of UIDeviceOrientation for RTCVideoFrame's rotation
#92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloudwebrtc
pushed a commit
that referenced
this pull request
Sep 14, 2023
Use UIInterfaceOrientation instead of UIDeviceOrientation for RTCVideoFrame's rotation
cloudwebrtc
added a commit
that referenced
this pull request
Sep 20, 2023
* Improve e2ee, add setSharedKey to KeyProvider. * update. * reset has_valid_key after RatchetKey. * update. * clone key_handler from share_key for each participant. * add RatchetSharedKey and ExportSharedKey. * make KeyProvider::SetSharedKey only valid when KeyProviderOptions::shared_key == true. * remove unused enum. * Fix memory leak when creating audio CMSampleBuffer #86 * add scalabilityMode for AV1. * fix bug for scalability-mode. * add scalability-mode support for VP9. * add failure tolerance for framecryptor. * add failureTolerance for android/objc. * fix: make H264's unencrypted_bytes consistent with js-sdk. * wip: ScalabilityModes for android. * update. * wip. * wip. * wip. * wip. * Fix camera rotation (#92) Use UIInterfaceOrientation instead of UIDeviceOrientation for RTCVideoFrame's rotation * done. * fix * update. * Expose audio sample buffers for Android (#89) * Initial draft * Working impl * doc and cleanup * doc update * add SetSifTrailer. * fix h264 freeze. --------- Co-authored-by: Hiroshi Horie <[email protected]> Co-authored-by: davidliu <[email protected]>
cloudwebrtc
pushed a commit
that referenced
this pull request
May 22, 2024
Added yuv_helper (#57) ABGRToI420, ARGBToI420 & ARGBToRGB24 (#65) more yuv wrappers (#87) Fix naming for yuv helper (#113) Fix camera rotation (#92) Fix missing `RTC_OBJC_TYPE` macros (#100) Co-authored-by: Théo Monnom <[email protected]> Co-authored-by: Hiroshi Horie <[email protected]>
Merged
cloudwebrtc
added a commit
that referenced
this pull request
May 30, 2024
[Mac/iOS] feat: Add RTCYUVHelper for darwin. (#28) Cross-platform `RTCMTLVideoView` for both iOS / macOS (#40) rotationOverride should not be assign (#44) [ObjC] Expose properties / methods required for AV1 codec support (#60) Workaround: Render PixelBuffer in RTCMTLVideoView (#58) Improve iOS/macOS H264 encoder (#70) fix: fix video encoder not resuming correctly upon foregrounding (#75). Fix camera rotation (#92) add PrivacyInfo.xcprivacy to darwin frameworks. (#112) Add NSPrivacyCollectedDataTypes key to xcprivacy file (#114) Thread-safe `RTCInitFieldTrialDictionary` (#116) Set RTCCameraVideoCapturer initial zoom factor (#121) Unlock configuration before starting capture session #122 Co-authored-by: Hiroshi Horie <[email protected]>
cloudwebrtc
added a commit
that referenced
this pull request
Jun 12, 2024
[Mac/iOS] feat: Add RTCYUVHelper for darwin. (#28) Cross-platform `RTCMTLVideoView` for both iOS / macOS (#40) rotationOverride should not be assign (#44) [ObjC] Expose properties / methods required for AV1 codec support (#60) Workaround: Render PixelBuffer in RTCMTLVideoView (#58) Improve iOS/macOS H264 encoder (#70) fix: fix video encoder not resuming correctly upon foregrounding (#75). Fix camera rotation (#92) add PrivacyInfo.xcprivacy to darwin frameworks. (#112) Add NSPrivacyCollectedDataTypes key to xcprivacy file (#114) Thread-safe `RTCInitFieldTrialDictionary` (#116) Set RTCCameraVideoCapturer initial zoom factor (#121) Unlock configuration before starting capture session #122 Co-authored-by: Hiroshi Horie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UIDeviceOrientationcontains states such as .faceUp, .faceDown which are not ideal for determining capture rotation and causes undefined behavior. This patch will use interface orientation instead.Especially when the interface rotation is locked (by user) it had an undesirable behavior.
Also fixes issue : livekit/client-sdk-swift#146