Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: using absolute PureSight product links #230

Merged
merged 1 commit into from
Mar 24, 2024

Conversation

michalcukierman
Copy link
Member

Description

Links to products do not work because the links are relative.

Motivation and Context

Carousel and product listing should work from all pages

Types of changes

  • Bug fix (non-breaking change which fixes an issue) labeled with bug
  • New feature (non-breaking change which adds functionality) labeled with enhancement
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code standards of this project.
  • My change requires updating the documentation. I have updated the documentation accordingly.

Copy link
Contributor

✅ Visual tests status

No visual changes detected.

Name Link
Commit 75a3928
Logs https://github.com/websight-io/starter/actions/runs/8403740967

@pawel-boguski-ds pawel-boguski-ds merged commit 8393dcf into main Mar 24, 2024
6 checks passed
@pawel-boguski-ds pawel-boguski-ds deleted the bugfix/puresigh-dynamic-links branch March 24, 2024 20:32
@github-actions github-actions bot locked and limited conversation to collaborators Mar 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants