Don't publish .babelrc file #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More and more npm packages contain ES2015+ code. As discussed in [this AMA](sindresorhus/ama#446), this causes a lot of troubles (Uglify and old browsers) for people. One possible solution is to transpile external dependencies, as discussed in [this issue on create-react-app](facebook/create-react-app#1125) and implemented in [this pull request](facebook/create-react-app#3776). This doesn't currently work with Webslides as the .babelrc file is published on npm. Here is a [small repo demonstrating the bug](https://github.com/oligot/webslides-babelrc). Running `npm run build` results in this error ``` ERROR in ./node_modules/webslides/static/js/webslides.js Module build failed: Error: Couldn't find preset "es2015" relative to directory ".../webslides-babelrc/node_modules/webslides" ``` By adding the .babelrc file to .npmignore, and removing the babel config in the _package.json_ file, the bug would go away once a new version of Webslides is published. This is basically the same PR as done for [v-tooltip](Akryum/floating-vue#90).
Codecov Report
@@ Coverage Diff @@
## master #106 +/- ##
=======================================
Coverage 90.17% 90.17%
=======================================
Files 19 19
Lines 641 641
Branches 128 128
=======================================
Hits 578 578
Misses 52 52
Partials 11 11Continue to review full report at Codecov.
|
|
Hey @oligot ! Thanks for taking the time and noticing this. I don't have much experience with webpack, I'm someone with more experience caught this! Hoping to release soon 1.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More and more npm packages contain ES2015+ code.
As discussed in this AMA, this causes a lot of troubles (Uglify and old browsers) for people.
One possible solution is to transpile external dependencies, as discussed in this issue on create-react-app and implemented in this pull request.
This doesn't currently work with Webslides as the .babelrc file is published on npm.
Here is a small repo demonstrating the bug.
Running
npm run buildresults in this errorBy adding the .babelrc file to .npmignore, and removing the babel config in the package.json file, the bug would go away once a new version of Webslides is published.
This is basically the same PR as done for v-tooltip.