Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

specify data encoding type 'binary' at hash#update #746

Merged
merged 1 commit into from
Jun 13, 2016
Merged

specify data encoding type 'binary' at hash#update #746

merged 1 commit into from
Jun 13, 2016

Conversation

tejasmanohar
Copy link
Contributor

@tejasmanohar tejasmanohar commented Jun 13, 2016 •
edited
Loading

Solves #716, which originated in Node v6 due to this breaking change.

@3rd-Eden 3rd-Eden merged commit f0c5699 into websockets:master Jun 13, 2016
@3rd-Eden
Copy link
Member

Thanks for the correction.

@tejasmanohar tejasmanohar deleted the fix/node_6_crypto_binary branch June 13, 2016 07:55
@tejasmanohar
Copy link
Contributor Author

tejasmanohar commented Jun 13, 2016 •
edited
Loading

No problem. Lmk when patch has been pushed to NPM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tejasmanohar @3rd-Eden