Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bug where outline does not update for inline elements #438

Merged
merged 7 commits into from
Nov 10, 2022
Merged

Fix a bug where outline does not update for inline elements #438

merged 7 commits into from
Nov 10, 2022

Conversation

rpominov
Copy link
Contributor

@rpominov rpominov commented Nov 10, 2022 •
edited
Loading

Fixes #433

Before requesting a review

  • if the PR is WIP - use draft mode
  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")
  • what kind of review is needed?
    • conceptual
    • detailed
    • with testing

Test cases

  • step by step interaction description and what is expected to happen

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env.example and the designer/env-check.js if mandatory

@vercel
Copy link

vercel bot commented Nov 10, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
webstudio-designer ✅ Ready (Inspect) Visit Preview Nov 10, 2022 at 2:41PM (UTC)

@rpominov rpominov requested a review from kof November 10, 2022 13:45
kof
kof approved these changes Nov 10, 2022
View reviewed changes
Copy link
Member

@kof kof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, a few naming improvements

@rpominov rpominov merged commit ebeb78a into main Nov 10, 2022
@rpominov rpominov deleted the 433_fix-outline branch November 10, 2022 14:49
@codebdy codebdy mentioned this pull request Sep 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kof kof kof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Outline is not always updating the size or position
2 participants
@rpominov @kof