Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'video-on-top' from VLC player launch options #1286

Merged
merged 1 commit into from
Apr 19, 2018

Conversation

terryhau
Copy link
Contributor

This command line option just sets the 'Always on top' setting in VLC.
The player will pop up in the foreground when playing a video from webtorrent without this option.

Having VLC always on top is very annoying when multi tasking.
If the user wants VLC always on top, they can set it in VLC preferences.

@Ropiel
Copy link

Ropiel commented Dec 20, 2017

I totally agree

With such a minimalist and handy software that's a pretty annoying option,please make that the "Floating on Top" option if unchecked works on vlc too.

@pastudan
Copy link

+1 This is a simple change. Any word on if this can be merged?

@feross
Copy link
Member

feross commented Apr 19, 2018

We added this option because the VLC window does not come to the front without it. We don't want the window to stay in the front, but there was no other way to focus it without the option.

All told, my opinion on this has changed and I think it's more annoying to have the option enabled so let's try disabling it and see how many complaints that generates :)

Copy link
Member

@feross feross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@feross feross merged commit cc78251 into webtorrent:master Apr 19, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants