Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent spectrogram being selected as the poster. #1368

Merged
merged 2 commits into from
Apr 30, 2018
Merged

Prevent spectrogram being selected as the poster. #1368

merged 2 commits into from
Apr 30, 2018

Conversation

Borewit
Copy link
Member

@Borewit Borewit commented Apr 26, 2018

@Borewit
Copy link
Member Author

Borewit commented Apr 26, 2018

Test torrent found on this page: Alvvays-Alvvays2014FLAC

Before:
spectrum

After this change:
fixed-spectrum

@feross
Copy link
Member

feross commented Apr 26, 2018

Nice. Why does this need to be -80? Would 0 be sufficient?

@Borewit
Copy link
Member Author

Borewit commented Apr 27, 2018

0 points would have no effect.
Prior to this change the 'spectrometer.jpg' would have got 0 points. 0 points are assigned to those images not matching any of the listed keyword / scores. So the assumption is that 0 point images are more likely to better choice for a poster then the spectrogram. Note that from these images, the largest will be selected.

The 0.8 * however is pointless, I will remove that one (was part of an unfinished attempt to balance a size score with a keyword score).

@Borewit
Copy link
Member Author

Borewit commented Apr 27, 2018

Idea on additional improvement of the poster selection algorithm:

Taking the album name from the metadata, and inject this as a dynamic keyword, would definitely improve the poster selection in a lot of cases.

Relates to the metadata update lifecycle #1340.

@Borewit
Copy link
Member Author

Borewit commented Apr 28, 2018

Thanks @ocheriaf !

Copy link
Member

@feross feross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@feross feross merged commit 4f41f59 into webtorrent:master Apr 30, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants