Update React and Material-UI #1483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borewit
approved these changes
Sep 27, 2018
| @@ -39,9 +39,6 @@ const TorrentPlayer = require('./lib/torrent-player') | |||
| // Perf optimization: Needed immediately, so do not lazy load it below | |||
| const TorrentListController = require('./controllers/torrent-list-controller') | |||
|
|
|||
| // Required by Material UI -- adds `onTouchTap` event | |||
| require('react-tap-event-plugin')() | |||
There was a problem hiding this comment.
Module is deprecated (react-tap-event-plugin), removed as a dependency as well ✔️
|
Thanks for reviewing @Borewit! 😃 |
mathiasvr
force-pushed
the
update-material-ui
branch
from
64cf780
to
390ea0b
Compare
remove react-tap-event-plugin, as it is not needed anymore.
mathiasvr
force-pushed
the
update-material-ui
branch
from
390ea0b
to
16c3476
Compare
DiegoRBaquero
approved these changes
Dec 12, 2018
|
Thanks a lot @DiegoRBaquero! 😃 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
react-tap-event-plugin, as it is not needed anymore.