Refine and fix building with zig #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttytm
force-pushed
the
build/update-zig-11-build
branch
from
7d8fbd3
to
6c99bad
Compare
|
ha? So you want to add 0.12 zig support to the webui? |
|
I think subsequent adjustments to 0.12 are best placed in zig-webui |
|
Oh, my problem, please ignore what I said above, I just checked the commit record I should also make a new adaptation on |
|
Yeah, this is just about continuing to support building the webui C library with the zig build system as it's already in there. All zig WRAPPER api code should continue to go to the zig-webui repo. |
|
I'm gonna finish the PR this likely tomorrow or the day after tomorrow. Unfortunately, there is a lot of work atm |
ttytm
force-pushed
the
build/update-zig-11-build
branch
4 times, most recently
from
9eef59d
to
1141dbe
Compare
ttytm
force-pushed
the
build/update-zig-11-build
branch
from
1141dbe
to
3b3ccdf
Compare
ttytm
force-pushed
the
build/update-zig-11-build
branch
from
857696a
to
9ca7c3c
Compare
hassandraga
reviewed
May 29, 2024
hassandraga
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR fixes and refines building with Zig.
The changes are also a preparation to allow a simple integration for building with Zig 0.12.0 in a follow-up.
The goal of this PR is to simplify the code while making it more expressive and extending functionality at the same time.
It also allows to zig-build with extended information. E.g. what is currently a silent build, can give info based on the build options, like:
It's not a huge diff, but still fairly big. So just reviewing and testing the new
build.zigresult locally might be an easier approach.