Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update linux webview positon fallback values values to match type declarations #377

Merged
merged 1 commit into from
May 31, 2024

Conversation

ttytm
Copy link
Member

@ttytm ttytm commented May 30, 2024

Fixes a warning when compiling on Linux caused by the webview struct taking uints but passing a negative value:

src/webui.c: In function ‘_webui_wv_show’:
src/webui.c:9728:45: warning: operand of ‘?:’ changes signedness from ‘int’ to ‘unsigned int’ due to unsignedness of other operand [-Wsign-compare]
 9728 |         webView->x = (win->x > 0 ? win->x : -1);
      |                                             ^~
src/webui.c:9729:45: warning: operand of ‘?:’ changes signedness from ‘int’ to ‘unsigned int’ due to unsignedness of other operand [-Wsign-compare]
 9729 |         webView->y = (win->y > 0 ? win->y : -1);
      |                                             ^~

@ttytm ttytm changed the title Update linux webview positon fallback values values to match type dec… Update linux webview positon fallback values values to match type declarations May 30, 2024
@hassandraga hassandraga merged commit 218a129 into webui-dev:main May 31, 2024
17 checks passed
@ttytm ttytm deleted the fix/sign-comp2 branch May 31, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants