Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove platform-dependent CSS and use browser titlebar on Firefox #398

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

malisipi
Copy link
Contributor

@malisipi malisipi commented Jun 6, 2024

I removed platform-dependent CSS and used Firefox default titlebar support.

  • Since Titlebar is handled by platform, titlebar is looking more consistent with system.
  • Since removed platform-dependent CSS, should be fixed issues (like Firefox Issue #85) and code should be more future-proof.
  • Untested on Windows and MacOS yet. If you test the PR on the platforms, can you share your test results.

resim

TODO:

  • Removed browser vendor name from titlebar. I need to run code on Browser Console (should not be confused with Web Console) and I can not find how to run via command-line.
  • Manage title (until accessing browser console) and icon of browser with HWID of browser window, in Windows.

Tested on:

  • Linux
  • MacOS
  • Windows

@malisipi malisipi changed the title Remove platform-dependent CSS and use browser titlebar Remove platform-dependent CSS and use browser titlebar on Firefox Jun 6, 2024
@hassandraga
Copy link
Member

Windows:

image

@malisipi
Copy link
Contributor Author

malisipi commented Jun 6, 2024

Actually if can we handle the browser window' HWID from PID in Windows, we can change title and browser logo by manually.
Potentially we can add a MutationObserver to handle title changes of page, and change it manually.

@hassandraga
Copy link
Member

if can we handle the browser window' HWID from PID in Windows

We can't get the exact PID of the window as Firefox create many child process..., and Firefox may add - Mozilla Firefox to the title at any time anyway. It's just too much work for one browser.

Right now, your PR makes Firefox title-bar looks native, and it's way better than the actual userChrome.css style, We can deal with - Mozilla Firefox later...

I will test it on my Mac then it's ready to merge.

@hassandraga
Copy link
Member

macOS:

image

@hassandraga
Copy link
Member

Title issue in macOS is another issue to deal with later...

image

@hassandraga
Copy link
Member

Thank you @malisipi for the PR.
You can verify, and merge when you want.

@malisipi
Copy link
Contributor Author

malisipi commented Jun 6, 2024

Right now, your PR makes Firefox title-bar looks native, and it's way better than the actual userChrome.css style, We can deal with - Mozilla Firefox later...

You can verify, and merge when you want.

So, I will verify the PR. I will search solution for titlebar, I will create a new PR if I found a good solution. You can merge the PR.

@malisipi malisipi marked this pull request as ready for review June 6, 2024 19:06
@neroist neroist merged commit b57a803 into webui-dev:main Jun 6, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants