Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include TLS builds in artifact uploads on Linux and macOS #413

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

ttytm
Copy link
Member

@ttytm ttytm commented Jun 13, 2024

No description provided.

@ttytm
Copy link
Member Author

ttytm commented Jun 13, 2024

It would leave out TLS builds when cross-compiling to Linux arm due to openssl.

Maybe just add it when github adds its arm runners compile on arm native?

@ttytm ttytm marked this pull request as ready for review June 13, 2024 14:32
@ttytm
Copy link
Member Author

ttytm commented Jun 13, 2024

What we could try is using the Zig builds. It could further simplify building and Zig is usually better in handling C than C 😅

@hassandraga hassandraga merged commit ea5540c into webui-dev:main Jun 13, 2024
23 checks passed
@ttytm ttytm deleted the ci/tls-linux-macos branch June 13, 2024 14:49
@hassandraga
Copy link
Member

It would leave out TLS builds when cross-compiling to Linux arm due to openssl

I see, let's try install it first.

Maybe just add it when github adds its arm runners compile on arm native?

I guess now it's a private beta, and the plan is to make it public this year...

What we could try is using the Zig builds

I don't mind using Zig to generate pre-built binaries, but many contributors know Makefile/CI scripts and not Zig.

Zig is usually better in handling C than C

I don't know, I'm not sure 🙂

@ttytm
Copy link
Member Author

ttytm commented Jun 13, 2024

I don't mind using Zig to generate pre-built binaries, but many contributors know Makefile/CI scripts and not Zig.

Yes we should definitely keep and continue to support and test this build path. Also not making Zig a requirement to build WebUI.

What I meant was just for building and cross compiling the binaries in CI runs that will be uploaded as releases.

@ttytm
Copy link
Member Author

ttytm commented Jun 13, 2024

Zig gets a bit of a reputation of being the better C. Even when just using C from Zig. It appears this is somehow becoming a meme on the internet atm..

Looking into it, its achievements are quite impressive. More companies start using Zig to do cross-compilation. I'm getting a bit of a fanboy too :D. So I would definitely experiment with it.

@hassandraga
Copy link
Member

Maybe just add it when github adds its arm runners compile on arm native?

Just to let you know, Linux ARM is ready to use, you can try it by creating a new linux_arm.yml and run it on buildjet-2vcpu-ubuntu-2204-arm.

Looking into it, its achievements are quite impressive

I have not yet fully tested Zig, but from public reviews, it seems people who have tested it are liking it so far, especially for compilation scripts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants