Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix condition for release steps when pushing tags #415

Merged
merged 1 commit into from
Jun 15, 2024

Conversation

ttytm
Copy link
Member

@ttytm ttytm commented Jun 15, 2024

I simplified the release condition too much with one of the recent updates. We would encounter an issue on the next tag release (I already did in another project after making a similar change).

While creating a tag is a push event, the ref_name is not the branch name like main but the tag's name. So, the condition would be false when it shouldn't be.

@ttytm ttytm marked this pull request as ready for review June 15, 2024 01:46
@hassandraga
Copy link
Member

image

Just to let you know, I'm testing the paid GitHub ARM runners... for some reason, the runners does not run!.
I'm planning to do more testing, if does not work, I may probably more to an external paid runners services... however, if any of those work, the CI scripts may get changed.

I still prefer a complete cross-compiling solution with TLS using default runners... but need much time to fully do it.

@ttytm
Copy link
Member Author

ttytm commented Jun 15, 2024

Yes I noticed the update. I don't have experience with github paid runners yet. There were always solutions without them. It'll be interesting to explore their functionalities. Let's see where things go.

@ttytm ttytm merged commit 9518b9e into webui-dev:main Jun 15, 2024
23 checks passed
@ttytm ttytm deleted the ci/fix-release-cond branch June 15, 2024 20:09
@ttytm
Copy link
Member Author

ttytm commented Jun 15, 2024

Solidifying the basics and improving testing in general is needed. The main repo still has no tests besides building. I think it will yield more benefits before starting endevours on more platforms.

@ttytm
Copy link
Member Author

ttytm commented Jun 16, 2024

Does the runners cost per usage? I think it's better to ask first before I also start doing tests.

@hassandraga
Copy link
Member

hassandraga commented Jun 16, 2024

Yes it cost, but it's cheap, 0.004 I guess... You can try it as many as you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants