Update handling of build variables #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttytm
changed the title
|
Since workflows have grown lager in the recent days. I would do minor updates to their structure in a followup. This should improve their speed, maintainability and also make it in general more cost effective in case of using paid runners. |
hassandraga
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes allows to have some flags set as env variables by only setting default variable values if they are not set.
E.g. this way it is possible to keep the include and lib flags for webui tls in the environment and it would suffice to just use the WEBUI_USE_TLS switch (changes are reflected in the workflows).
The current way of building should continue to work as is it currently does.