Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve incompatible ptr warning to fix compatibility with gcc-14 #442

Merged
merged 2 commits into from
Jul 6, 2024

Conversation

ttytm
Copy link
Member

@ttytm ttytm commented Jul 6, 2024

Related to: #430 (comment)

  • The error is reflected in the CI of the first commit (https://github.com/webui-dev/webui/actions/runs/9818994139/job/27112104411?pr=442).

  • The second commit contains the quickfix.

  • To prevent such issues and make them visible immediately, it would help to eventually remove the -w from the WEBUI_BUILD_FLAGS (replacing it with, e.g., -Wall). Imho., warnings that are within the sphere of influence of the library and not caused by third-party should be resolved instead of suppressed.

    WEBUI_BUILD_FLAGS := -o webui.o -I"$(MAKEFILE_DIR)/include/" -c "$(MAKEFILE_DIR)/src/webui.c" -I"$(WEBUI_TLS_INCLUDE)" $(TLS_CFLAG) -w

@hassandraga hassandraga merged commit 89495f9 into webui-dev:main Jul 6, 2024
25 of 26 checks passed
@hassandraga
Copy link
Member

remove the -w from the WEBUI_BUILD_FLAGS

Yes, why not, but only for debug version.

second commit contains the quickfix

Thank you

@ttytm
Copy link
Member Author

ttytm commented Jul 6, 2024

Yes, why not, but only for debug version.

Good idea

@ttytm ttytm deleted the fix/gcc-14-compatibility branch July 6, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants