Skip to content

Commit

Permalink
Remove pyrightconfig.json file as it doesn't belong here
Browse files Browse the repository at this point in the history
This is a VSCode specific json file. Better to put the setting directly
into VSCode. Also if you're using Pylance, this already includes Pyright
so you don't need to add settings for Pyright specifically.

Note: There are some performance improvements and semantic differences
over mypy. See disccusion here [1] and [2].

"python.analysis.diagnosticSeverityOverrides": {
    "reportUndefinedVariable": "none",
    "reportGeneralTypeIssues": "none",
    "reportIncompatibleMethodOverride": "error",
    "reportMissingParameterType": "error",
    "reportMissingTypeStubs": "error",
    "typeCheckingMode": "basic",
    "venv": ".venv",
    "venvPath": "."
},

The setting "python.analysis.diagnosticSeverityOverrides" in .vscode is
specific to Pylance, the default language server for Python in Visual
Studio Code.

[1] https://news.ycombinator.com/item?id=34222407
[2] https://github.com/microsoft/pyright/blob/main/docs/mypy-comparison.md
  • Loading branch information
webventurer committed Jan 13, 2024
1 parent dc9f4b1 commit bb71ce0
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions pyrightconfig.json

This file was deleted.

0 comments on commit bb71ce0

Please sign in to comment.